Fix and CI static builds #3765
Merged
Fix and CI static builds #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl doesn't like this identifier
this is needed for static linking to work properly
this seems to break in Musl/Static with: terminate called after throwing an instance of 'std::bad_function_call' what(): bad_function_call
Ericson2314
changed the title
|
I guess I'll call it semi-wip, hah. It works, but it would be nice to accomplish some things differently. |
|
Also needs |
|
#3507 has a good explanation of why the getHome* changes are needed. |
Ericson2314
changed the title
Better to get creative than just sprinkle arbitrary underscores.
edolstra
reviewed
Sep 25, 2020
edolstra
reviewed
Sep 25, 2020
And remove one that we didn't actually need to add
Per the comments, the underlying issue is libarchive/libarchive#1446, knowing this allows the hack to be much more targetted.
|
@edolstra OK think this is finally cleaned up and ready! |
|
Ugh, tests failed because evidently the channel doesn't include NixOS/nixpkgs@9f5ba92 yet? Oh right, I got to bump the flake lock. |
|
Well, and now there are different problems: errors installing nix in the mac CI runner. :( |
Ericson2314
force-pushed
the
fix-and-ci-static-builds
branch
from
68d5666
to
1d09923
Compare
|
BTW I noticed that the which would be nice to get rid of to get a really minimal closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like static builds because we can use to make demos more self-contained and less spooky on systems without a regular installation of Nix.
There number of things that didn't work out of the box also makes us think CI would be a good idea. Static linking shouldn't be this invasive for most programs, but a few things have accumulated. Hopefully we can eventually fix them more elegantly by using a non-bespoke build system (that e.g. could use pkg-config private deps to figure out the right link order).