Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8216: Don't show floating text on autoreplace if cost is 0 #8244

Merged
merged 1 commit into from Jun 27, 2020
Merged

Fix #8216: Don't show floating text on autoreplace if cost is 0 #8244

merged 1 commit into from Jun 27, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Jun 27, 2020

Not actually tested, but it's the only use of the function that isn't already guarded by an "if != 0" check.

glx22
glx22 approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but makes sense :)

@LordAro LordAro merged commit 218db00 into OpenTTD:master Jun 27, 2020
@LordAro LordAro deleted the bug8216 branch June 27, 2020 23:00
@techgeeknz
Copy link
Contributor

Not actually tested, but it's the only use of the function that isn't already guarded by an "if != 0" check.

If it's the only function invocation not guarded, and if the guard is important; then why isn't it ShowCostOrIncomeAnimation's responsibility to check its parameter?

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Jul 27, 2020
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Nov 8, 2020
@LordAro LordAro mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LordAro @techgeeknz @glx22