Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shattered-pixel-dungeon: 0.8.0b -> 0.8.1 #91767

Merged
merged 1 commit into from Jun 29, 2020
Merged

shattered-pixel-dungeon: 0.8.0b -> 0.8.1 #91767

merged 1 commit into from Jun 29, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jun 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020

/marvin opt-in
/marvin needs_review

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 29, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020

oops
/status needs_review

danieldk
danieldk approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91767 1

1 package built:
- shattered-pixel-dungeon

Works as expected.

@danieldk danieldk merged commit 7801614 into NixOS:master Jun 29, 2020
@fgaz fgaz deleted the shattered-pixel-dungeon/0.8.1 branch June 30, 2020 09:48
@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @danieldk