Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akira-unstable: 2019-10-12 -> 2020-05-01 #91829

Merged
merged 1 commit into from Jun 30, 2020
Merged

akira-unstable: 2019-10-12 -> 2020-05-01 #91829

merged 1 commit into from Jun 30, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jun 30, 2020 •
edited

Motivation for this change

Update akira to the latest commit, also dropped the patch for compilation on vala 0.44 or later as this was fixed upstream.

Not sure if the version should be unstable-2020-05-01, but as the attribute name is already akira-unstable, and this wasn't done in the past, i just left it as is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from worldofpeace and Br1ght0ne June 30, 2020 11:33
@IvarWithoutBones IvarWithoutBones changed the title akira: 2019-10-12 -> 2020-05-01 akira-unstable: 2019-10-12 -> 2020-05-01 Jun 30, 2020
worldofpeace
worldofpeace approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

@worldofpeace worldofpeace merged commit a17ab53 into NixOS:master Jun 30, 2020
@IvarWithoutBones IvarWithoutBones deleted the akira-update branch June 30, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @worldofpeace