[CSP] Add WPT tests for inheritance with window.open. #24395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2274602
branch
2 times, most recently
from
948ff3d
to
bc860e8
Compare
There are WPT tests about CSP inheritance when opening local-scheme. This is tested for iframe. Testing for iframes is good, testing for both iframes and opened window is better. Initially, I wanted to reproduce bug 1073126, but failed to do so. I still want to keep the tests. Bug: chromium:1073126 Change-Id: I4c363037d556bf93f37d43dd5b84a1da608d5e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274602 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#785017}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2274602
branch
from
bc860e8
to
cc55a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are WPT tests about CSP inheritance when opening local-scheme.
This is tested for iframe. Testing for iframes is good, testing for
both iframes and opened window is better.
Initially, I wanted to reproduce bug 1073126, but failed to do so. I
still want to keep the tests.
Bug: chromium:1073126
Change-Id: I4c363037d556bf93f37d43dd5b84a1da608d5e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274602
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785017}