Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wpt/html/coep/require-corp-about-{blank,srcdoc}.html #24392

Merged
merged 1 commit into from Jun 30, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 30, 2020

  • platform/mac-mac10.13/.../require-corp-about-blank-expected.txt
    is redundant - it's same as the base expectation.
  • platform/mac-mac10.14/.../require-corp-about-blank-expected.txt
    is wrong - the test always fails on the platform (and the failures
    are suppressed by TestExpectations).
  • wpt/html/coep/require-corp-about-blank.html always fails because
    COEP is only effective on secure contexts
    (Secure Contexts and Cross-Origin-Embedder-Policy whatwg/html#4930). Rename it to
    wpt/html/coep/require-corp-about-blank.https.html
  • wpt/html/coep/require-corp-about-srcdoc.html always fails because
    COEP is only effective on secure contexts
    (Secure Contexts and Cross-Origin-Embedder-Policy whatwg/html#4930). Rename it to
    wpt/html/coep/require-corp-about-srcdoc.https.html
  • Remove redundant TestExpectations entries.

Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783875}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

 - platform/mac-mac10.13/.../require-corp-about-blank-expected.txt
   is redundant - it's same as the base expectation.
 - platform/mac-mac10.14/.../require-corp-about-blank-expected.txt
   is wrong - the test always fails on the platform (and the failures
   are suppressed by TestExpectations).
 - wpt/html/coep/require-corp-about-blank.html always fails because
   COEP is only effective on secure contexts
   (whatwg/html#4930). Rename it to
   wpt/html/coep/require-corp-about-blank.https.html
 - wpt/html/coep/require-corp-about-srcdoc.html always fails because
   COEP is only effective on secure contexts
   (whatwg/html#4930). Rename it to
   wpt/html/coep/require-corp-about-srcdoc.https.html
 - Remove redundant TestExpectations entries.

Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783875}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants