Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_shell: remove #91764

Merged
merged 1 commit into from
Jun 29, 2020
Merged

aws_shell: remove #91764

merged 1 commit into from
Jun 29, 2020
+0 −46

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Jun 29, 2020

It appears to have been broken for the last few releases and has had no
upstream updates for the last 2 years. I originally committed this but
didn't add myself to maintainers.

Motivation for this change

Clean out broken packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Mic92
Copy link
Member

Mic92 commented Jun 29, 2020

You removed awscli instead of aws_shell

aws_shell: remove
c7705e6 
It appears to have been broken for the last few releases and has had no
upstream updates for the last 2 years. I originally committed this but
didn't add myself to maintainers.
@cransom cransom force-pushed the cransom/remove-aws_shell branch from 639ab50 to c7705e6 Compare June 29, 2020 18:30
@cransom
Copy link
Contributor Author

cransom commented Jun 29, 2020

Wooo oops. I'm sure that was subconcious wishful thinking.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 29, 2020
@Mic92 Mic92 merged commit dea62a1 into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cransom @Mic92