Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-container: Pass through several Nix flags #91835

Merged
merged 1 commit into from Jul 1, 2020
Merged

nixos-container: Pass through several Nix flags #91835

merged 1 commit into from Jul 1, 2020

Conversation

edolstra
Copy link
Member

Motivation for this change

Since nixos-container calls nix-env / nix-build, it's useful to support various evaluation-related options.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edolstra
nixos-container: Pass through several Nix flags
ed49c90 
Since nixos-container calls nix-env / nix-build, it's useful to
support various evaluation-related options.
@edolstra edolstra added 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 0.kind: enhancement labels Jun 30, 2020
@edolstra edolstra merged commit deb220a into NixOS:master Jul 1, 2020
@edolstra edolstra deleted the nixos-container-nix-flags branch July 1, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@edolstra