Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apache Pulsar #91837

Closed
wants to merge 2 commits into from
Closed

Add Apache Pulsar #91837

wants to merge 2 commits into from

Conversation

samdroid-apps
Copy link
Contributor

Motivation for this change

This PR adds support for the Apache Pulsar message bus in NixOS. Running Pulsar involves 3 components - the Zookeeper, the Bookkeeper Bookie and the Pulsar Broker. All component are distributed by Apache Pulsar together.

This PR:

  • Adding the pulsar package (containing the official distribution of zookeeper, bookie and broker)
  • Adds the services.pulsar module, made up of a zookeeper, bookie and broker systemd service
  • Adds 2 nixos tests for common configurations:
    • A single-node setup, where zookeeper, bookie and broker run on the same machine
    • A more complex multi-node setup, with two bookkeepers (for data integrity) and all services on components machines
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samdroid-apps
pulsar: init at 2.6.0
46cae93
@samdroid-apps
nixos/pulsar: init
43147d1 
Adds an Apache Pulsar module and two nixos tests covering common use cases:

- single-node cluster - all 3 components run on the same server
- multi-node cluster - all components run a separate server, and there are two bookkeeper instances
@aahmed-se
Copy link

aahmed-se commented Jun 30, 2020 •
edited

will close this since you are picking up the task #65324

@aahmed-se aahmed-se mentioned this pull request Jun 30, 2020
Closed
@samdroid-apps samdroid-apps mentioned this pull request Jul 1, 2020
Closed
10 tasks
@lucperkins lucperkins mentioned this pull request Jul 6, 2020
Closed
10 tasks
@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@jlesquembre
Copy link
Member

Is there a reason for this PR to be staled? It seems ready. Other than fixing the merge conflicts, and bumping the version, is there anything to be done?

It'd be nice to have Pulsar on nixpkgs. I see more people are interested in that, there were other PRs to add Pulsar:
#92393
#65324

@samdroid-apps @lucperkins @aahmed-se Are you still interested in getting this merged? If not, I could try to finish the work and get it merged.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 31, 2023
@aahmed-se
Copy link

Please update and finish it , overall it looks fine to me.

@AndersonTorres
Copy link
Member

Closing as abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samdroid-apps @aahmed-se @jlesquembre @AndersonTorres @ryantm