Setting innerHTML in a template element in an inactive document should not crash. #24384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 29, 2020
…d not crash. Bug: 1100176 Test: html/semantics/scripting-1/the-template-element/template-element/template-set-inner-html-in-inactive-document-crash.html Change-Id: I1d2ad61aead0d8f14952ae9b8e49d855d773e86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273798 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783693}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2273798
branch
from
25afbdc
to
57a88a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1100176
Test: html/semantics/scripting-1/the-template-element/template-element/template-set-inner-html-in-inactive-document-crash.html
Change-Id: I1d2ad61aead0d8f14952ae9b8e49d855d773e86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273798
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783693}