Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flightgear: 2019.1.1 -> 2020.1.3, simgear: 2020.1.{1 -> 3} #91793

Merged
merged 2 commits into from Jul 1, 2020
Merged

flightgear: 2019.1.1 -> 2020.1.3, simgear: 2020.1.{1 -> 3} #91793

merged 2 commits into from Jul 1, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Jun 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion
Copy link
Contributor Author

turion commented Jun 29, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 29, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from 7c6f434c June 29, 2020 22:08
@veprbl veprbl linked an issue Jun 29, 2020 that may be closed by this pull request
flightgear is broken #91787
Closed
@aanderse
Copy link
Member

Does this release support the new openscenegraph release?

#77799

@veprbl
Copy link
Member

veprbl commented Jun 30, 2020

Flightgear would not build for me with this:

CMake Error at CMakeModules/Translations.cmake:38 (translation_dir_list):
  translation_dir_list Function invoked with incorrect arguments for function
  named: translation_dir_list

Let's ask ofborg to reproduce (might not work because of empty meta.hydraPlatforms):
@GrahamcOfBorg build flightgear

@turion
Copy link
Contributor Author

turion commented Jun 30, 2020

/status needs_work

@turion
Copy link
Contributor Author

turion commented Jul 1, 2020

I reverted the version to 2020.1.2, this seems to build. Best to have something working at all. We can bump the version further later.

@turion
Copy link
Contributor Author

turion commented Jul 1, 2020

/status needs_review

@7c6f434c 7c6f434c merged commit be97764 into NixOS:master Jul 1, 2020
@turion turion deleted the 91787_flightgear branch July 1, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_changes marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flightgear is broken
4 participants
@turion @aanderse @veprbl @7c6f434c