Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.arc-menu: 43 -> 47 #91814

Merged
merged 1 commit into from Jul 28, 2020
Merged

gnomeExtensions.arc-menu: 43 -> 47 #91814

merged 1 commit into from Jul 28, 2020

Conversation

tpanum
Copy link
Contributor

@tpanum tpanum commented Jun 30, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tpanum tpanum changed the title Updated arc-menu to version 47, and resolved issue with gmenu patching arc-menu: 43 -> 47 Jun 30, 2020
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 30, 2020
@ofborg ofborg bot requested a review from dkabot June 30, 2020 08:47
dkabot
dkabot approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@dkabot dkabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, changes are easy enough to read and it runs fine on my end.

@dywedir
Copy link
Member

dywedir commented Jul 20, 2020

@tpanum thanks! Could you please also change the commit message?

@tpanum
Copy link
Contributor Author

tpanum commented Jul 27, 2020

@dywedir Should be fixed now.

@ofborg ofborg bot requested a review from dkabot July 27, 2020 06:41
@dywedir
Copy link
Member

dywedir commented Jul 27, 2020

Whoops, this should be changed to gnomeExtensions.arc-menu: 43 -> 47

@tpanum
Copy link
Contributor Author

tpanum commented Jul 28, 2020

@dywedir Fair enough, should be compliant now.

@dywedir dywedir merged commit 80b1900 into NixOS:master Jul 28, 2020
@dywedir dywedir changed the title arc-menu: 43 -> 47 gnomeExtensions.arc-menu: 43 -> 47 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkabot dkabot Awaiting requested review from dkabot

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tpanum @dywedir @dkabot @Janik-Haag