Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easypdkprog: init at 1.2 #91671

Merged
merged 2 commits into from Jun 28, 2020
Merged

easypdkprog: init at 1.2 #91671

merged 2 commits into from Jun 28, 2020

Conversation

david-sawatzke
Copy link
Contributor

@david-sawatzke david-sawatzke commented Jun 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The udev rules stuff is taken from the openocd package, but I'm not sure if it works

danieldk
danieldk approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this derivation! I have added a bunch of suggestions for improvements.

pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
@david-sawatzke
Copy link
Contributor Author

@danieldk Thanks for the review, should be fine now

@danieldk danieldk self-requested a review June 28, 2020 05:23
danieldk
danieldk suggested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starts to look good! I added another suggestion to merge postInstall (which was currently not working) and installPhase. postInstall is typically only useful when you use an unchanged installPhase.

Could you split the change where you add yourself to maintainers.nix to a separate commit with the following message?

maintainers: add david-sawatzke

This commit should be ordered before the commit where you add the derivation.

Let me know if you need any help!

pkgs/development/tools/misc/easypdkprog/default.nix Outdated Show resolved Hide resolved
@david-sawatzke
Copy link
Contributor Author

Thanks, regarding:

merge postInstall (which was currently not working)

It seems to work now after being merged, but I don't understand why it didn't work before. Do you have any idea why that's the case?

@danieldk
Copy link
Contributor

It seems to work now after being merged, but I don't understand why it didn't work before. Do you have any idea why that's the case?

preInstall and postInstall are run as hooks in installPhase. The default installPhase looks like this:

installPhase() {
    runHook preInstall

    # Do the installPhase stuff

    runHook postInstall
}

So if you override installPhase they are not run anymore.

danieldk
danieldk approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks a lot!

Result of nixpkgs-review pr 91671 1

1 package built:
- easypdkprog

@danieldk danieldk merged commit 96ccfba into NixOS:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-sawatzke @danieldk