Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8129: Crash if a news message expires while viewing the endgame screen #8243

Merged
merged 1 commit into from Jun 27, 2020
Merged

Fix #8129: Crash if a news message expires while viewing the endgame screen #8243

merged 1 commit into from Jun 27, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Jun 27, 2020

OpenTTD/src/news_gui.cpp

Lines 998 to 1001 in b84d61e

/* There is no status bar, so no reason to show news;
* especially important with the end game screen when
* there is no status bar but possible news. */
if (FindWindowById(WC_STATUS_BAR, 0) == nullptr) return;

Move (and duplicate) the check to the MoveToNext*Item functions

@LordAro LordAro merged commit 4c45448 into OpenTTD:master Jun 27, 2020
@LordAro LordAro deleted the bug8129 branch July 27, 2020 17:12
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Jul 27, 2020
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LordAro @michicc @glx22