Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: cleaning up obsolete overrides (8/x) #91653

Merged
merged 1 commit into from Jun 27, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jun 27, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

  • terminal-progress-bar: -doJailbreak
  • lifted-base: -doJailbreak
  • case-insensitive: -doJailbreak
  • lens: -disableCabalFlag

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md._

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jun 27, 2020

@GrahamcOfBorg build haskellPackages.terminal-progress-bar
@GrahamcOfBorg build haskellPackages.lifted-base
@GrahamcOfBorg build haskellPackages.case-insensitive
@GrahamcOfBorg build haskellPackages.lens

terminal-progress-bar: -doJailbreak
lifted-base: -doJailbreak
case-insensitive: -doJailbreak
lens: -disableCabalFlag
@cdepillabout
Copy link
Member

@svmhdvn I think if you rebase you might need to re-run the ofborg checks:

@GrahamcOfBorg build haskellPackages.terminal-progress-bar
@GrahamcOfBorg build haskellPackages.lifted-base
@GrahamcOfBorg build haskellPackages.case-insensitive
@GrahamcOfBorg build haskellPackages.lens

@cdepillabout
Copy link
Member

Okay, well ofborg was able to run those pretty fast. I guess it was basically able to just reuse the old output.

Thanks!

@cdepillabout cdepillabout merged commit ad6dd78 into NixOS:haskell-updates Jun 27, 2020
@svmhdvn svmhdvn deleted the overrides-8 branch June 28, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants