vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter #91656

colemickens · 2020-06-27T04:06:18Z

Motivation for this change

Update vimplugins and add:

Things done

teto

so last time I merged a neovim plugin for lsp, there were some complaints that we shouldn't package for an unreleased software. nvim 0.5 is still a few months away but works quite well already so I still believe it's fine to merge.

colemickens · 2020-07-05T09:17:58Z

I've rebased this and also made ./update.py use GITHUB_API_TOKEN if defined. This makes updating considerably faster since you have use higher parallelism without 429s.

I think there are more than a few people using neovim 0.5, particularly for the features that these plugins revolve around. It certainly wouldn't be the first unstable thing packaged in nixpkgs, and at least one of them has a tagged release. Hopefully this can be merged. Thanks for considering/reviewing!

teto · 2020-07-05T10:42:00Z

pkgs/misc/vim-plugins/generated.nix

+    pname = "completion-nvim";
+    version = "2020-07-05";
+    src = fetchFromGitHub {
+      owner = "haorenW1025";


a few plugins recently moved under the org "nvim-lua" so htis is the new home

teto · 2020-07-05T10:43:07Z

while at it would you mind packaging https://github.com/nvim-lua/lsp-status.nvim

colemickens · 2020-07-05T22:21:51Z

@teto Sure, I've redone the PR with lsp-status.nvim included as well.

Also, I was able to use -p 16 to redo this, which was 16 times faster than can be achieved without GITHUB_API_TOKEN.

colemickens · 2020-07-05T22:32:52Z

this iteration isn't ready for merging, btw.

colemickens · 2020-07-05T23:04:18Z

Looks like I had missed another dependency of completion-treesitter.

@teto your requested plugin breaks my system config (it looks like maybe vimplugins tests that vim can startup properly?) When I point at this commit, it works. Maybe you can file an issue/pr on lsp-status.nvim for this? I don't quite have context, or time to test this outside of nixpkgs. colemickens/lsp-status.nvim@3982991

I'm going to back out the lsp-status-nvim commit and push what works.

Mic92 · 2020-07-07T09:01:42Z

pkgs/misc/vim-plugins/update.py

@@ -71,6 +70,15 @@ def f_retry(*args: Any, **kwargs: Any) -> Any:

    return deco_retry

+def mkreq(url: str) -> urllib.request.Request:


Suggested change

def mkreq(url: str) -> urllib.request.Request:

def makeRequest(url: str) -> urllib.request.Request:

Mic92 · 2020-07-07T09:01:56Z

pkgs/misc/vim-plugins/update.py

-            urllib.request.urlopen(
-                self.url(f"blob/{self.branch}/.gitmodules"), timeout=10
-            ).close()
+            req = mkreq(self.url(f"blob/{self.branch}/.gitmodules"))


Suggested change

req = mkreq(self.url(f"blob/{self.branch}/.gitmodules"))

req = makeRequest(self.url(f"blob/{self.branch}/.gitmodules"))

Mic92 · 2020-07-07T09:18:08Z

Should the token be made a requirement? I mean without it, one does run into request limits quite fast, so it is not really usable.

colemickens · 2020-07-07T09:24:26Z

@Mic92 I don't know. I didn't want to make a "breaking change" if i I didn't have to. It does update with -p 1, it's just slow. I'd rather leave it to another PR, to be frank. (I went ahead and did this next round of fixups and rebased/pushed.)

gvolpe · 2020-07-08T18:41:12Z

Any chance you can update coc-metals as part of this PR as well? The current version in Nixpkgs is super outdated. The new repository is https://github.com/scalameta/coc-metals

I tried to update a few plugins but I was also blocked by #91339

colemickens · 2020-07-08T19:45:09Z

I don't think so, sorry. I've already churned this PR once for a change I wound up having to back out. I'd really like to see this merged so we can unblock everyone.

gvolpe · 2020-07-08T20:09:05Z

No problems, I'll try to put up a follow up PR.

flokli · 2020-07-08T20:34:46Z

Let's merge this 👍 Thanks for your work!

gvolpe · 2020-07-12T10:56:17Z

This still doesn't work for me. I have set up a GITHUB_API_TOKEN and some packages managed to be downloaded at first but then again Github doesn't seem to like the amount of requests.

<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...
<urlopen error [Errno 113] No route to host>, Retrying in 3 seconds...

colemickens · 2020-07-12T22:04:43Z

Unless I made some other coding error, "No route to host" is a very different error condition than an HTTP 429.

Mic92 · 2020-07-12T22:33:03Z

Agreed. Sounds like a local network issue.

gvolpe · 2020-07-12T22:35:40Z

I don't think I have any network issues, it would be nice if someone else could try and see if this works for them.

colemickens · 2020-07-12T22:39:38Z

I just ran it https://asciinema.org/a/mFnijt0sBehQyxZWUeRKb2Iu2 (and rotated the access token).

gvolpe · 2020-07-12T22:43:19Z

Wow, that really works for you! Thanks for that. Any chance you could try and make the same changes I made to vim-plugin-names here and then run the script again?

It's really late in my timezone but I promise to post what happens on my end tomorrow first thing. I wish this worked for me too...

colemickens · 2020-07-12T22:47:42Z

Sure, let's move the conversation over to your PR. Maybe a new issue would be best if you (or anyone) winds up finding something wrong with the update script.

colemickens requested a review from jonringer as a code owner June 27, 2020 04:06

ofborg bot added 6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jun 27, 2020

teto approved these changes Jun 27, 2020

View reviewed changes

colemickens force-pushed the vimplugins branch 4 times, most recently from 513f320 to 31938c7 Compare July 5, 2020 09:13

colemickens changed the title ~~vimplugins: update, add completion-nvim, completion-treesitter~~ vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter Jul 5, 2020

colemickens force-pushed the vimplugins branch from 31938c7 to e999439 Compare July 5, 2020 09:18

ofborg bot added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Jul 5, 2020

teto reviewed Jul 5, 2020

View reviewed changes

colemickens force-pushed the vimplugins branch from e999439 to 17f83c1 Compare July 5, 2020 22:21

colemickens force-pushed the vimplugins branch from 17f83c1 to b514709 Compare July 5, 2020 22:26

colemickens force-pushed the vimplugins branch from b514709 to d29cebc Compare July 5, 2020 22:51

colemickens force-pushed the vimplugins branch from d29cebc to 06694d3 Compare July 5, 2020 23:25

ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 11-100 labels Jul 5, 2020

colemickens force-pushed the vimplugins branch 2 times, most recently from 85c4cde to 05396f7 Compare July 7, 2020 01:00

Mic92 reviewed Jul 7, 2020

View reviewed changes

ofborg bot requested a review from jagajaga July 7, 2020 09:17

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jul 7, 2020

colemickens added 5 commits July 7, 2020 02:24

vimplugins: update.py uses GITHUB_API_TOKEN if available

a957776

vimPlugins.nvim-treesitter: init at 2020-07-05

82b171b

vimPlugins.completion-nvim: init at 2020-07-05

a778c30

vimPlugins.completion-treesitter: init at 2020-06-26

3b418a8

vimPlugins: update

794a34b

colemickens force-pushed the vimplugins branch from 48445be to 794a34b Compare July 7, 2020 09:24

Mic92 approved these changes Jul 7, 2020

View reviewed changes

colemickens mentioned this pull request Jul 8, 2020

vim plugins can't be updated (github 429) #91339

Closed

flokli merged commit 62ff70e into NixOS:master Jul 8, 2020

gvolpe mentioned this pull request Jul 12, 2020

Update coc-metals vim plugin #92993

Closed

9 tasks

colemickens deleted the vimplugins branch December 30, 2022 01:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter #91656

vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter #91656

colemickens commented Jun 27, 2020

teto left a comment

colemickens commented Jul 5, 2020

teto Jul 5, 2020

teto commented Jul 5, 2020

colemickens commented Jul 5, 2020

colemickens commented Jul 5, 2020

colemickens commented Jul 5, 2020

Mic92 Jul 7, 2020

Mic92 Jul 7, 2020

Mic92 commented Jul 7, 2020

colemickens commented Jul 7, 2020

gvolpe commented Jul 8, 2020

colemickens commented Jul 8, 2020

gvolpe commented Jul 8, 2020

flokli commented Jul 8, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020

Mic92 commented Jul 12, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020

		@@ -71,6 +70,15 @@ def f_retry(args: Any, *kwargs: Any) -> Any:

		return deco_retry

		def mkreq(url: str) -> urllib.request.Request:

	def mkreq(url: str) -> urllib.request.Request:
	def makeRequest(url: str) -> urllib.request.Request:

	req = mkreq(self.url(f"blob/{self.branch}/.gitmodules"))
	req = makeRequest(self.url(f"blob/{self.branch}/.gitmodules"))

vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter #91656

vimplugins: update.py supports GitHub Access tokens; add completion-nvim, completion-treesitter #91656

Conversation

colemickens commented Jun 27, 2020

Motivation for this change

Things done

teto left a comment

Choose a reason for hiding this comment

colemickens commented Jul 5, 2020

teto Jul 5, 2020

Choose a reason for hiding this comment

teto commented Jul 5, 2020

colemickens commented Jul 5, 2020

colemickens commented Jul 5, 2020

colemickens commented Jul 5, 2020

Mic92 Jul 7, 2020

Choose a reason for hiding this comment

Mic92 Jul 7, 2020

Choose a reason for hiding this comment

Mic92 commented Jul 7, 2020

colemickens commented Jul 7, 2020

gvolpe commented Jul 8, 2020

colemickens commented Jul 8, 2020

gvolpe commented Jul 8, 2020

flokli commented Jul 8, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020

Mic92 commented Jul 12, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020

gvolpe commented Jul 12, 2020

colemickens commented Jul 12, 2020