Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syslinux: make reproducible #91672

Merged
merged 1 commit into from Jul 2, 2020
Merged

syslinux: make reproducible #91672

merged 1 commit into from Jul 2, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jun 27, 2020 •
edited

Motivation for this change

I saw it on https://r13y.com/ and I changed stuff in syslinux recently.
This time I tested if it still builds on i686.

The reason why I needed to import the patch is that it was missing memdisk/Makefile and it tried to use git to determine a date.

Both patches are fetched and HEXDATE is set through makeFlags.

I also changed the url of the patch I introduced in #85094 to one that should be more stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @grahamc @samueldr

@ofborg ofborg bot requested a review from samueldr June 27, 2020 16:27
@jtojnar
Copy link
Contributor

jtojnar commented Jun 27, 2020

The reason why I needed to import the patch is that it was missing memdisk/Makefile and it tried to use git to determine a date.

Could we pass HEXDATE=0x00000000 to makeFlags instead?

@ajs124
Copy link
Member Author

ajs124 commented Jun 27, 2020

That seems to works as well, yes. We could probably go back to the arch patch with that, if we wanted to. Do we want to?

@jtojnar
Copy link
Contributor

jtojnar commented Jun 27, 2020

Yeah, I think that would be nicer.

@ajs124
Copy link
Member Author

ajs124 commented Jun 29, 2020

This supersedes/includes #82839.

@bjornfor bjornfor merged commit 5756862 into NixOS:master Jul 2, 2020
@bjornfor bjornfor mentioned this pull request Jul 2, 2020
Closed
10 tasks
@ajs124 ajs124 deleted the reprod/syslinux branch July 2, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @jtojnar @bjornfor