Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whisper: init at 2.0.1 #91647

Merged
merged 1 commit into from Aug 21, 2020
Merged

whisper: init at 2.0.1 #91647

merged 1 commit into from Aug 21, 2020

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Jun 27, 2020

Motivation for this change

Whisper init.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbedo jbedo mentioned this pull request Jun 27, 2020
Closed
@jbedo jbedo changed the title whisper: init at 2.0 whisper: init at 2.0.1 Jul 2, 2020
jollheef
jollheef suggested changes Jul 3, 2020
View reviewed changes
pkgs/applications/science/biology/whisper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/whisper/default.nix Outdated
license = licenses.gpl3;
homepage = "https://github.com/refresh-bio/whisper";
maintainers = with maintainers; [ jbedo ];
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why it shouldn't build on macOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation only mentioned windows and linux, but I think it should work on macos. I don't have macos to try, so I've updated platforms to all and we'll see if CI builds.

pkgs/applications/science/biology/whisper/default.nix Outdated Show resolved Hide resolved
@jbedo jbedo force-pushed the whisper branch 2 times, most recently from 8323aba to 0f981d2 Compare July 4, 2020 21:59
@jbedo
Copy link
Contributor Author

jbedo commented Jul 4, 2020

Updated for x86_64 only.

jollheef
jollheef approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@jollheef jollheef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balsoft
Copy link
Member

balsoft commented Jul 5, 2020

Why is buildPhase set explicitly? If there is a reason, please respect enableParallelBuilding attribute.

@jbedo
Copy link
Contributor Author

jbedo commented Jul 5, 2020

Removed, was unnecessary.

@Lassulus Lassulus merged commit de25713 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@jollheef jollheef jollheef approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbedo @balsoft @jtojnar @jollheef @Lassulus