Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decred: 1.1.2 -> 1.5.0 #68798

Merged
merged 1 commit into from Jun 28, 2020
Merged

decred: 1.1.2 -> 1.5.0 #68798

merged 1 commit into from Jun 28, 2020

Conversation

oneingan
Copy link
Contributor

@oneingan oneingan commented Sep 14, 2019 •
edited

Motivation for this change

Old version was outdated and broken.
Also migrated to new buildGoModule.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @juaningan

@oneingan @marsam
dcrd/dcrwallet: 1.1.2 -> 1.5.1
4f7a56f 
dcrwallet: 1.1.2 -> 1.4.1

Update modSha256 sums

Downgrade drcd to Go 1.12

update to 1.5.0
@oneingan
Copy link
Contributor Author

Also impacts: #52469

@ofborg ofborg bot requested a review from kalbasit September 14, 2019 14:50
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

Can you rebase your commit on master?

@oneingan
Copy link
Contributor Author

Can you rebase your commit on master?

done

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

I get different checksums for both:

error: build of '/nix/store/6w4icww6xjwzp5xqx25xac2i9f1b79y1-dcrd-1.4.0-go-modules.drv' on 'ssh://nix@rose.r' failed: hash mismatch in fixed-output derivation
'/nix/store/nc2jxm1dc8pqg33hv6v379xzagp93ikl-dcrd-1.4.0-go-modules':
  wanted: sha256:0wm3n6c0s1nc9blaahwmd4cc6xna3xj1jpygy98gifb6c16n0nvw
  got:    sha256:02i3s7h2z0l4sqbl31j82dq6pgqr0i7c2rqjblcfi08bvqnqkgi7

  hash mismatch in fixed-output derivation '/nix/store/kqc7aplw8k1lqzzjb3mdv7hfw4ggb9fh-dcrwallet-1.4.1-go-modules':
    wanted: sha256:122cf4szwv3sm3kca7n23h34jkql7pz4yi0hiwqr9kkb46z2a3v6
    got:    sha256:11cqdppa3fx9g3cj086imn64dscm9jawnp5q88gzlbfzy0w6inyq

@oneingan
Copy link
Contributor Author

oneingan commented Sep 24, 2019 •
edited

Im building right now with nix-env -f . -iA dcrd while sitting in branch.

EDIT: also fails, I can update modSha256, but dont understand why fails if the derivation is the same?

@oneingan
Copy link
Contributor Author

oneingan commented Sep 24, 2019 •
edited

Seems like 'go 1.12 -> 1.13 upgrade' is having problems with modules SHA determinism. Link: #68135 (comment)

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

I think so.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

@GrahamcOfBorg build dcrd dcrwallet

1 similar comment
@oneingan
Copy link
Contributor Author

@GrahamcOfBorg build dcrd dcrwallet

@ttuegel ttuegel removed their request for review September 28, 2019 18:53
@oneingan
Copy link
Contributor Author

do you need something to merge?

@ofborg ofborg bot requested a review from kalbasit October 23, 2019 14:36
@oneingan
Copy link
Contributor Author

oneingan commented Dec 3, 2019

Is there something I can do to merge this?

@oneingan oneingan changed the title decred: 1.1.2 -> 1.4.x decred: 1.1.2 -> 1.5.0 Dec 16, 2019
@oneingan
Copy link
Contributor Author

Updated to new 1.5.0 and squashed commits

@stale
Copy link

stale bot commented Jun 13, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 13, 2020
@oneingan oneingan requested a review from mmahut as a code owner June 28, 2020 00:42
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2020
@marsam
Copy link
Contributor

marsam commented Jun 28, 2020

@GrahamcOfBorg build dcrd dcrwallet

@marsam marsam merged commit 2fceb35 into NixOS:master Jun 28, 2020
@oneingan oneingan deleted the decred branch June 28, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oneingan @Mic92 @marsam