New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] lossless-cut: Init at version 3.23.7 #91683
Conversation
|
||
yarnNix = ./yarn.nix; | ||
yarnLock = "${src}/yarn.lock"; | ||
packageJSON = "${src}/package.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, this relies on Import From Derivation, which is not allowed in nixpkgs. Seems like other packages put this file into nixpkgs directly.
Also these two lines seem to be set by default:
nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix
Lines 226 to 227 in db5bbef
packageJSON ? src + "/package.json", | |
yarnLock ? src + "/yarn.lock", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the three lines specifying yarnNix
, yarnLock
and packageJSON
and deleted yarn.nix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean to say that the default settings will work for nixpkgs. You might need to copy file to nixpkgs repo at least for packageJSON
to avoid IFD.
Create a simple default.nix that make use of mkYarnPackage. Create `yarn.nix` using `yarn2nix`. Add entry lossless-cut to `all-packages.nix`. Takes 50 minutes to build on my slow usb-stick-based NixOS system. Closure size: 1,614,691,296 bytes, where $out/libexec/lossless-cut/node_modules occupies 686,152,094 bytes. Problem: $out/bin is empty. TODO: Add something to the `installPhase`.
ed1b3ca
to
7307130
Compare
Add a wrapper that use electron to execute the app
dcd32a3
to
30c67b3
Compare
I marked this as stale due to inactivity. → More info |
Close due to difficulties faced during source-packaging Electron apps. |
This is a draft to package lossless-cut .
As a beginner, I may need help from others often.
Any advise, contributions or corrections are more than welcome. If you would like to be added as a maintainer, please go ahead or inform me.
Motivation for this change
LosslessCut is an intuitive GUI application that cuts videos/audios losslessly.
If applied, we will be able to natively install this app.
Things done
Create a simple
default.nix
that makes use ofmkYarnPackage
.Create
yarn.nix
usingyarn2nix
.Add entry lossless-cut to
all-packages.nix
.Takes 50 minutes to build on my slow usb-stick-based NixOS system,
and most of the time is spent on the node dependencies.
Closure size: 1,614,691,296 bytes, where
$out/libexec/lossless-cut/node_modules occupies 686,152,094 bytes.
Problem: $out/bin is empty.
TODO: Add something to the
installPhase
.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)