Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot/gui: Fix cross-compilation breakage #173

Merged
merged 1 commit into from Jun 26, 2020

Conversation

samueldr
Copy link
Member

Turns out that mruby's require looks at the actual file name (not the
link) when deciding between loading bytecode or ruby code.

Cross-compilation appends the system to derivation names.

Fun ensues.

This fixes the issue by using runCommand, for which it doesn't happen.


Why didn't I catch this? I tested with QEMU! Native compilation!

Turns out that `mruby`'s require looks at the actual file name (not the
link) when deciding between loading bytecode or ruby code.

Cross-compilation appends the system to derivation names.

Fun ensues.

This fixes the issue by using `runCommand`, for which it doesn't happen.
@samueldr samueldr added the 4. type: bug Something isn't working label Jun 26, 2020
@samueldr samueldr merged commit e689208 into NixOS:master Jun 26, 2020
@samueldr samueldr deleted the fix/aarch64-boot-menu branch June 26, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant