Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neomutt: enable on darwin #91637

Merged
merged 1 commit into from Jun 27, 2020
Merged

neomutt: enable on darwin #91637

merged 1 commit into from Jun 27, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jun 26, 2020

Motivation for this change
  • Changelog
  • enable on darwin (via enabling elinks on darwin)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jun 26, 2020

The update is already done in da1b17f, enabling elinks on darwin for neomutt support on darwin seems fine to me, please rebase your branch onto latest master.

@sikmir
Copy link
Member Author

sikmir commented Jun 26, 2020

Rebased.

@sikmir sikmir changed the title neomutt: 20200619 -> 20200626 neomutt: enable on darwin Jun 26, 2020
@Ma27
Copy link
Member

Ma27 commented Jun 27, 2020

@GrahamcOfBorg build neomutt

@Ma27 Ma27 merged commit 052c130 into NixOS:master Jun 27, 2020
@sikmir sikmir deleted the neomutt branch June 27, 2020 19:53
@doronbehar
Copy link
Contributor

FYI elinks is now insecure because it depends on spidermonkey_37 which is insecure now (ever since 5ad4389 ). Switch to w3m should be no problem at all and produce almost identical results (either lynx, w3m or elinks are used for generating manual.txt out of manual.html). PR: #99497

@mweinelt mweinelt mentioned this pull request Oct 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@vrthra vrthra Awaiting requested review from vrthra

@cstrahan cstrahan Awaiting requested review from cstrahan

@erikryb erikryb Awaiting requested review from erikryb

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @Ma27 @doronbehar