postfix: Add submissions option for postfix and test #91691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typetetris
changed the title
RFC 8314 suggests, for end user submission of mails, SMTP over TLS on port 465 should be used. Closes NixOS#91690
typetetris
force-pushed
the
add-smtps-to-postfix
branch
from
f6a8a4f
to
a288521
Compare
|
I was looking for a solution to this. Thanks for looking into it! I deployed it to my server and it works as expected. The only problem I noticed was some options missing from the submissionsOptions, because the nixos-mailserver module only sets the submissionOptions, but this can be easily added over there. |
ghost
approved these changes
Jul 6, 2020
ghost
merged commit
|
FYI I created an MR based on this for the Simple NixOS Mailserver project: |
tnias
reviewed
Sep 19, 2020
| elif state == 2 and line.startswith(" ") and "smtpd_tls_security_level=encrypt" in line: | ||
| success = True | ||
| elif state == 2 and not line.startswith(" "): | ||
| state == 3 |
There was a problem hiding this comment.
@typetetris Typo: state == 3 instead of state = 3?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 8314 suggests, for end user submission of
mails, SMTP over TLS on port 465 should be used.
So let't support running that directly.
Closes #91690
Motivation for this change
Provide an easy way to offer SMTP over TLS via direct nixos configuration option. See
RFC 8314.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)