Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: 0.2.11 -> 0.3.0 #91665

Merged
merged 1 commit into from Jun 27, 2020
Merged

undervolt: 0.2.11 -> 0.3.0 #91665

merged 1 commit into from Jun 27, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jun 27, 2020 •
edited

Motivation for this change

georgewhewell/undervolt@246ef5b

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu mentioned this pull request Jun 27, 2020
Merged
10 tasks
jollheef
jollheef approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@jollheef jollheef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LGTM
  • Tested on NixOS // Xeon E-2176M, latest stable kernel release

danieldk
danieldk approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 91665 1

1 package built:
- undervolt

Thanks @Atemu for the version bump and @jollheef for testing!

@danieldk danieldk merged commit 226bded into NixOS:master Jun 27, 2020
@Atemu Atemu deleted the undervolt-update branch July 30, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jollheef jollheef jollheef approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @danieldk @jollheef