Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-kea-exporter: init at 0.4.1 #91663

Merged
merged 3 commits into from May 14, 2021
Merged

prometheus-kea-exporter: init at 0.4.1 #91663

merged 3 commits into from May 14, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

This is the Prometheus exporter for the ISC Kea DHCP daemon, I want to monitor DHCP metrics with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jun 27, 2020

Can you please add a module for the exporter?

@mweinelt mweinelt marked this pull request as draft June 28, 2020 19:37
@stale
Copy link

stale bot commented Dec 25, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 25, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 12, 2021
@mweinelt mweinelt marked this pull request as ready for review May 12, 2021 19:53
@mweinelt mweinelt requested a review from WilliButz as a code owner May 12, 2021 19:53
@mweinelt
Copy link
Member Author

mweinelt commented May 12, 2021 •
edited

Thanks for your patience, I did a thing.

There is no kea module, so this is a bit messy right now.

WilliButz
WilliButz approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input nixosTests is missing for the package but otherwise this looks good to merge 👍

pkgs/servers/monitoring/prometheus/kea-exporter.nix Outdated Show resolved Hide resolved
@WilliButz WilliButz merged commit 94b2848 into NixOS:master May 14, 2021
@mweinelt mweinelt deleted the kea-exporter branch May 14, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @Ma27 @WilliButz