Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: allow strings in options again #91680

Closed
wants to merge 1 commit into from
Closed

undervolt: allow strings in options again #91680

wants to merge 1 commit into from

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jun 27, 2020 •
edited

#90144 changed the undervolt config
options' types to ints which broke backwards compatibility with older configs
where strings were required

This lets you use ints or strings, whichever you prefer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
undervolt: allow strings in options again
c045d7e 
NixOS#90144 changed the undervolt config
options' types to ints which broke backwards compatibility with older configs
where strings were required

This lets you use ints or strings, whichever you prefer
@Atemu Atemu mentioned this pull request Jun 27, 2020
Merged
10 tasks
@veprbl veprbl requested a review from pbogdan June 27, 2020 21:17
@Atemu Atemu closed this Aug 9, 2020
@Atemu Atemu deleted the undervolt-types branch November 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan Awaiting requested review from pbogdan

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Atemu