Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio-udev-rules: init at 4.3.4 #91679

Closed
wants to merge 1 commit into from
Closed

platformio-udev-rules: init at 4.3.4 #91679

wants to merge 1 commit into from

Conversation

f4814
Copy link
Contributor

@f4814 f4814 commented Jun 27, 2020

Motivation for this change

The platformio UDEV rules are not shipped with the platformio package.

Tagging @mogorman @makefu (the maintainers of the platformio package)

Things done

Add a platformio-udev-rules package containing the udev rules provided by the project. I am not sure if creating
a new package is the correct thing to do. If patching the platformio package to contain the udev rules is the better way, then tell me, please.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu
Copy link
Contributor

makefu commented Jun 28, 2020 •
edited

Hi @f4814 and thanks for your contribution!
Actually i'd think that patching the platformio package would be favorable. Some documentation somewhere(tm) would be nice to show that adding the package to the services.udev.packages helps setting up the rules.

@f4814
Copy link
Contributor Author

f4814 commented Jun 28, 2020

Thank you for the feedback. In that case I'll create another PR.

@f4814 f4814 mentioned this pull request Jul 2, 2020
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Jul 11, 2020

closed in favor of #92000.

@flokli flokli closed this Jul 11, 2020
@f4814 f4814 deleted the init-platformio-udev branch July 11, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f4814 @makefu @flokli