-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reproduce: Only download the needed commit #789
base: master
Are you sure you want to change the base?
Conversation
@Mic92 Any idea who I should reach out to for hydra changes? |
It's mainly maintained by @edolstra but @basvandijk and @grahamc also can merge changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against a live Hydra, LGTM 👍
Doesn't this break the next line:
|
It says |
It means that the evaluation result may no longer be the same, which is a bad thing for a script called "reproduce". |
Sounds like I need to modify hydra to pass the revCount in as a parameter to the template. |
On something like github this is super efficient due to git/git@68ee628 But in general it should be more efficient since the entire nixpkg history doesn't need to be downloaded. I've manually tested this by fatchin a reproduce script from hydra.
I'm 30% positive what I've done will work. The revCount is produced by the Git and Hg Plugins, but I totally can't figure out how the inputs to reproduce.tt get passed in (I see the controller file, but I don't see where it's actually rendered, or what type anything is). If someone can point me in the right direction, that would be awesome. |
On something like github this is super efficient due to
git/git@68ee628
But in general it should be more efficient since the entire nixpkg
history doesn't need to be downloaded.
I've manually tested this by fetching a reproduce script from hydra + modifying it to have these changes.