Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: make (nix-shell) prompt label unselectable #490

Closed
wants to merge 2 commits into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 27, 2020

Screenshot:

image

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 27, 2020

This works but we might want to leave the prompts in the code and just make them unselectable using CSS, see NixOS/nix#3741

@samueldr
Copy link
Member

The accessbility implications (if any) would need to be checked for which is preferrable between a CSS-derived prefix, or disabling selection via CSS.

A quasi-accessibility issue that exists with CSS-derived content is that user agents without CSS may not get that content. E.g. some crawlers, or more importantly, text-based (console) browsers.

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 27, 2020

Yeah, that was my concern as well. For regular browsers, ::before should be seen be screen readers IIRC. (Edit: Yup)

@samueldr
Copy link
Member

Yes, I wonder if there are other accessibility issues. Accessibility is hard!

Though I know that changing the contents via CSS is fraught with perils for some user agents. You're ending up losing some of the context. I'm thinking the most likely problematic user-agent (for the home page) would not be text browsers, but crawlers making "answer" based boxes. Though, in the manuals, definitely text-based browsers would end up losing context.

Additionally, changing the contents via CSS in cases like here pushes too much knowledge about the contents into the semantics, and then the presentation layer. It's not really wrong, but it's not exactly neat either.

I'm curious to hear opinions of others about that.

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 27, 2020

Opened #492, which is IMHO a better approach. The prompt is part of the screen just like the command or the output.

@samueldr
Copy link
Member

samueldr commented Jun 27, 2020

Opened #490, which is IMHO a better approach. The prompt is part of the screen just like the command or the output.

Or #492? :)

(I got confused when following the link.)

@jtojnar jtojnar closed this Jul 3, 2020
@jtojnar jtojnar deleted the homepage-shell-prompt branch July 7, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants