[Gecko Bug 1648796] Mark a handful of tests with user-scalable=no. #24366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android, if user-scalable=no is not set, Gecko uses the "minimum scale size" as the scrollport size, to allow for the user zooming out all the way to the minimum allowed scale. This has a number of effects, such as dropping the layout scroll range to zero for the root scrollframe. This can causes a number of WPT tests to fail; they currently pass only because the minimum scale size changes take effect after the test is already done. However, moving the minimum scale size changes to happen earlier causes these tests to fail. It's better to modify the tests to disable this behaviour, so that the assumptions in the test are not invalidated. Differential Revision: https://phabricator.services.mozilla.com/D81355 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1648796 gecko-commit: dc28a52cb810537acb394dd00d6cc91aeefa1063 gecko-integration-branch: autoland gecko-reviewers: hiro
wpt-pr-bot
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, if user-scalable=no is not set, Gecko uses the "minimum scale size"
as the scrollport size, to allow for the user zooming out all the way to the
minimum allowed scale. This has a number of effects, such as dropping the
layout scroll range to zero for the root scrollframe. This can causes a
number of WPT tests to fail; they currently pass only because the minimum
scale size changes take effect after the test is already done. However,
moving the minimum scale size changes to happen earlier causes these tests
to fail. It's better to modify the tests to disable this behaviour, so that the
assumptions in the test are not invalidated.
Differential Revision: https://phabricator.services.mozilla.com/D81355
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1648796
gecko-commit: dc28a52cb810537acb394dd00d6cc91aeefa1063
gecko-integration-branch: autoland
gecko-reviewers: hiro