python3Packages.jenkinsapi: fix build #91673
Conversation
|
@rski thanks for opening your first PR on nixpkgs! :) |
|
@jonringer very gentle poke, just making sure this hasn't fallen through the cracks. |
There was a problem hiding this comment.
I went on family vacation right after posting the other comment.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
python3Packages.jenkinsapi: fix build
rski
changed the title
rski
force-pushed
the
jenkinsapi
branch
2 times, most recently
from
ff19b41
to
2187060
Compare
|
@jonringer thanks for the comments, I've incorporated the suggestions. I hope I am not coming off as pushy, I'm certainly not expecting anything immediately. I was just making sure this was not buried under a huge pile of incoming PR volume 😃 |
|
WFM, non-nixos linux x86_64. On macos (tested 10.14), it seems You could either disable the tests for darwin ( Either way, rebase this to an updated |
|
@risicle Thanks for the review! I ended up disabling the tests completely on macOS and rebased to master |
nix-env -f default.nix -iA python38Packages.jenkinsapi now works. Here is a list of all the things done: - fixed the dependency list which was lacking some packages - changed checkPhase. This called python setup.py test by default, which is very much not what jenkinsapi does upstream. This resulted in simple_post_logger.py being imported, which called serve_forever(), manifesting as a hang - tox decided to install pbr every time and fails and also tried to run tests across multiple python versions, so I just made checkPhase call pylint/pycodestyle/py.test directly. - disabled systests which try to run jenkins - disabled misc broken tests. There are some calls in them that should have been mocked but the mocks don't take effect for some reason, resulting in failed requests to localhost. - removed needless inputs. nose and unittest2 are not needed, not even in python2 - disabled tests on darwin, as requests-kerberos is apparently broken
nix-env -f default.nix -iA python38Packages.jenkinsapi now works.
Here is a list of all the things done:
which is very much not what jenkinsapi does upstream. This resulted in
simple_post_logger.py being imported, which called serve_forever(),
manifesting as a hang
run tests across multiple python versions, so I just made checkPhase
call pylint/pycodestyle/py.test directly.
have been mocked but the mocks don't take effect for some reason,
resulting in failed requests to localhost.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)