Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: clarify that the service is unofficial #91666

Merged
merged 1 commit into from Jun 27, 2020
Merged

undervolt: clarify that the service is unofficial #91666

merged 1 commit into from Jun 27, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jun 27, 2020

Motivation for this change

#90144 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
undervolt: clarify that the service is unofficial
2c7402b 
The original warning almost made it sound like the service was made by or
somehow connected to Intel which is not the case
@grahamc grahamc merged commit 38060ee into NixOS:master Jun 27, 2020
@grahamc
Copy link
Member

grahamc commented Jun 27, 2020

Thanks!

@Atemu Atemu deleted the undervolt-warning branch July 30, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atemu @grahamc