Fix #8221: Subtitle - No Bridge Type Given Size #8240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error box for going over max the lengths for each of the bridge type was given the "...bridge too long" subtitle.
TrevorShelton
changed the title
TrevorShelton
changed the title
glx22
reviewed
Jun 27, 2020
src/bridge_gui.cpp
Outdated
| @@ -426,9 +426,12 @@ void ShowBuildBridgeWindow(TileIndex start, TileIndex end, TransportType transpo | |||
| default: break; | |||
| } | |||
|
|
|||
| bool any_available = 0; | |||
There was a problem hiding this comment.
Suggested change
| bool any_available = 0; | |
| bool any_available = false; |
src/bridge_gui.cpp
Outdated
| @@ -437,8 +440,14 @@ void ShowBuildBridgeWindow(TileIndex start, TileIndex end, TransportType transpo | |||
| /* Add to terraforming & bulldozing costs the cost of the | |||
| * bridge itself (not computed with DC_QUERY_COST) */ | |||
| item.cost = ret.GetCost() + (((int64)tot_bridgedata_len * _price[PR_BUILD_BRIDGE] * item.spec->price) >> 8) + infra_cost; | |||
| any_available = 1; | |||
There was a problem hiding this comment.
Suggested change
| any_available = 1; | |
| any_available = true; |
Per glx22's suggestion.
LordAro
approved these changes
Jun 28, 2020
LordAro
added
the
backport requested
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Jul 30, 2020
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Jul 30, 2020
LordAro
pushed a commit
that referenced
this pull request
Aug 9, 2020
glx22
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error box for going over max the lengths for each of the bridge types was given the "...bridge too long" subtitle.