Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

fix inconsistency in manual abstraction examples #21

Closed
wants to merge 1 commit into from
Closed

fix inconsistency in manual abstraction examples #21

wants to merge 1 commit into from

Conversation

susano
Copy link

@susano susano commented Jun 27, 2020

Motivation for this change

In manual "5.2. Abstractions", the statement "enablePHP = true" was missing instead of being abstracted in the examples.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

Make a PR against https://github.com/NixOS/nixpkgs/

@domenkozar domenkozar closed this Jun 29, 2020
@susano
Copy link
Author

susano commented Jul 6, 2020

Thank you. Also looks like a PR there already exists. NixOS/nixpkgs#88505

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@susano @domenkozar