Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shell prompts to the text #492

Merged
merged 5 commits into from Jul 7, 2020
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 27, 2020

They are part of the screen output just like the command or the printout.

Used shell-prompt class to avoid collision with Docbook’s prompt.

Screenshot:

image

They are part of the screen output just like the command or the printout.

Used shell-prompt class to avoid collision with Docbook’s prompt.
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and added few minor bits

@garbas garbas merged commit c77b251 into NixOS:master Jul 7, 2020
@jtojnar
Copy link
Contributor Author

jtojnar commented Jul 7, 2020

Thanks. However, the space should be part of the prompt, otherwise it gets copied and then the command will not be saved into shell history.

@garbas
Copy link
Member

garbas commented Jul 7, 2020

ah right, i'll fix it asap.

@jtojnar jtojnar deleted the shell-prompts branch July 7, 2020 14:31
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 20, 2020

Looks like this was forgotten in the new design.

@garbas
Copy link
Member

garbas commented Sep 22, 2020

@samueldr ping

@Majsvaffla
Copy link

I installed nix today, following https://nixos.org/download.html#nix-install-windows, and noticed the prompt character was also selectable. I wanted to open an issue or MR myself but then I found this one. Since this one was merged almost three years ago, how come the changes havn't made it to the live website yet?

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 28, 2023

Looks like the stylesheet where the prompt is made unselectable is no longer used? Probably needs to be moved to https://github.com/NixOS/nixos-common-styles

@Majsvaffla
Copy link

Looks like the stylesheet where the prompt is made unselectable is no longer used? Probably needs to be moved to https://github.com/NixOS/nixos-common-styles

Alright, I opened an MR over there 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants