Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polar: init at unstable-2021-01-12 #91677

Merged
merged 1 commit into from Apr 6, 2021
Merged

polar: init at unstable-2021-01-12 #91677

merged 1 commit into from Apr 6, 2021

Conversation

jluttine
Copy link
Member

Motivation for this change

Add polar package for reading Polar watch data. Also, add NixOS program module for defining the required udev rules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine force-pushed the polar-init branch 2 times, most recently from 8e75db3 to b1f747d Compare June 28, 2020 15:03
@jluttine jluttine force-pushed the polar-init branch 2 times, most recently from 5d40870 to 30c2a5c Compare November 19, 2020 17:58
@jluttine
Copy link
Member Author

I updated the version and removed the nixos module. Is there anything else to fix or is this good now?

@SuperSandro2000 SuperSandro2000 changed the title Polar: init polar: init at unstable-2020-09-07 Jan 18, 2021
SuperSandro2000
SuperSandro2000 requested changes Mar 21, 2021
View reviewed changes
pkgs/tools/misc/polar/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/polar/default.nix Outdated Show resolved Hide resolved
@jluttine jluttine force-pushed the polar-init branch 2 times, most recently from 578bf69 to b549544 Compare March 21, 2021 12:15
@jluttine
Copy link
Member Author

I'll still update the package as the pinned commit is already a bit old.

@jluttine jluttine changed the title polar: init at unstable-2020-09-07 polar: init at unstable-2021-01-12 Mar 21, 2021
@jluttine
Copy link
Member Author

Alright, updated the package and the dependencies.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit a230fd4 into NixOS:master Apr 6, 2021
@jluttine jluttine deleted the polar-init branch April 6, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@evils evils evils left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @SuperSandro2000 @markuskowa @evils