Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowsocks-v2ray-plugin: init at 1.3.1 #95567

Merged
merged 2 commits into from Aug 22, 2020
Merged

shadowsocks-v2ray-plugin: init at 1.3.1 #95567

merged 2 commits into from Aug 22, 2020

Conversation

ahrzb
Copy link

@ahrzb ahrzb commented Aug 16, 2020 •
edited

Motivation for this change

A shadowsocks plugin which obfuscates the traffic using v2ray. Useful in countries like Iran, China, etc where governments block shadowsocks traffic.

Things done
  • [*] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [*] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [*] Fits CONTRIBUTING.md.

@ahrzb
Copy link
Author

ahrzb commented Aug 16, 2020 •
edited

Is the name OK? shouldn't it be shadowsocks-v2ray/shadowsocks-v2ray-plugin or something?

@ofborg ofborg bot requested a review from kalbasit August 16, 2020 10:00
zowoq
zowoq reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the name OK? shouldn't it be shadowsocks-v2ray/shadowsocks-v2ray-plugin or something?

shadowsocks-v2ray-plugin may be better.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/networking/v2ray-plugin/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/v2ray-plugin/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/v2ray-plugin/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/v2ray-plugin/default.nix Outdated Show resolved Hide resolved
@ahrzb
Copy link
Author

ahrzb commented Aug 17, 2020

Dear @zowoq, thank you for your comments 👍

@zowoq
Copy link
Contributor

zowoq commented Aug 17, 2020

Are you going change the name? #95567 (review)

@ahrzb
Copy link
Author

ahrzb commented Aug 17, 2020

Oops, sorry for that

@ahrzb
Copy link
Author

ahrzb commented Aug 17, 2020

Should I also change the pname?

@zowoq
Copy link
Contributor

zowoq commented Aug 17, 2020

Yes, please change the pname.

@ahrzb
Copy link
Author

ahrzb commented Aug 17, 2020

Done ^^

@zowoq zowoq changed the title v2ray-plugin: init at 1.3.1 shadowsocks-v2ray-plugin: init at 1.3.1 Aug 17, 2020
@zowoq
Copy link
Contributor

zowoq commented Aug 22, 2020

@ofborg build shadowsocks-v2ray-plugin

@zowoq zowoq merged commit 829dd22 into NixOS:master Aug 22, 2020
This was referenced Aug 23, 2020
Closed
Merged
@ahrzb ahrzb deleted the v2ray-plugin branch October 18, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahrzb @zowoq @Janik-Haag