foot: init at 1.4.4 #95596
Merged
foot: init at 1.4.4 #95596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
requested changes
Aug 17, 2020
doronbehar
reviewed
Aug 17, 2020
|
@GrahamcOfBorg build foot fuzzel |
|
Weird, don't know why it didn't work out for me. Am I supposed to be able to run this on Xorg? |
|
No, it is wayland only! |
doronbehar
requested changes
Aug 17, 2020
Comment on lines
1
to
4
| { stdenv, fetchgit, fcft, freetype, pixman, libxkbcommon, fontconfig, wayland | ||
| , meson, ninja, ncurses, scdoc, tllist, wayland-protocols, pkg-config | ||
| }: |
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchgit, fcft, freetype, pixman, libxkbcommon, fontconfig, wayland | |
| , meson, ninja, ncurses, scdoc, tllist, wayland-protocols, pkg-config | |
| }: | |
| { stdenv | |
| , fetchgit | |
| , pkg-config | |
| , fcft | |
| , freetype | |
| , pixman | |
| , libxkbcommon | |
| , fontconfig | |
| , wayland | |
| , meson | |
| , ninja | |
| , ncurses | |
| , scdoc | |
| , tllist | |
| , wayland-protocols | |
| }: |
There was a problem hiding this comment.
For my taste these just convert horizontal space into vertical space without a real benefit to readability. I reduced horizontal space somewhat and split the inputs by category more obviously.
doronbehar
reviewed
Aug 17, 2020
doronbehar
reviewed
Aug 17, 2020
ryantm
reviewed
Aug 22, 2020
|
|
||
| src = fetchgit { | ||
| url = "https://codeberg.org/dnkl/foot.git"; | ||
| rev = "${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "${version}"; | |
| rev = version; |
|
Result of 3 packages built:- fcft - foot - fuzzel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
add
foota simple and fast terminal emulator for wayland based offcftfont rendering.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)