Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the same logic as in
nix run
, but accessible as a nixfunction.
Motivations for this change
Since
nix run
will have that logic, I think it's good to also try using it inside of nixpkgs. It will force us to improvepname
attributes so that they map to the default binary. And also expose weaknesses in the heuristic.There are a lot of times in nixpkgs where we have these patterns:
which can now be replaced with:
Not all of these can be replaced but there are ~5k of those in nixpkgs using this heuristic:
$ rg '}/bin/' | wc -l
There was a previous attempt with some discussion a long time ago, which this replaces: #67392
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)