Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.18.6 -> 1.18.8 #95613

Merged
merged 1 commit into from Aug 17, 2020
Merged

kubernetes: 1.18.6 -> 1.18.8 #95613

merged 1 commit into from Aug 17, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 16, 2020 •
edited

Motivation for this change

Update k8s to the latest patch release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @johanot

@jonringer
Copy link
Contributor

@GrahamcOfBorg test kubernetes.dns
@GrahamcOfBorg test kubernetes.rbac

jonringer
jonringer approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage
tests pass

https://github.com/NixOS/nixpkgs/pull/95613
2 packages built:
kubectl kubernetes

@jonringer
Copy link
Contributor

I'll wait for ofborg to finish checks

but, the v for version is usually left off for commits:

kubernetes: 1.18.6 -> 1.18.8

some repo's will prefix the version tags with v just to help separate those tags from others

@saschagrunert
kubernetes: 1.18.6 -> 1.18.8
ee75577 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title kubernetes: v1.18.6 -> v1.18.8 kubernetes: 1.18.6 -> 1.18.8 Aug 16, 2020
@saschagrunert
Copy link
Member Author

I'll wait for ofborg to finish checks

but, the v for version is usually left off for commits:

kubernetes: 1.18.6 -> 1.18.8

some repo's will prefix the version tags with v just to help separate those tags from others

Thanks for the hint, I removed the prefix.

@ofborg ofborg bot requested review from johanot and offlinehacker August 16, 2020 19:53
@jonringer jonringer merged commit ceed263 into NixOS:master Aug 17, 2020
@saschagrunert saschagrunert deleted the kubernetes branch August 17, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@johanot johanot Awaiting requested review from johanot

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @jonringer