Submit/3dslicer binary #95514
Submit/3dslicer binary #95514
Conversation
using binary version because compiling from source is much more effort to maintain because the build scripts use git and download files themselves etc.
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
| description = "The world's most popular open source database"; }; | ||
| }; | ||
|
|
||
| in x // { lib = x; } |
There was a problem hiding this comment.
generally this isn't needed, lib.getLib <drv> will do this logic for us
| homepage = http://www.mysql.com/; | ||
| description = "The world's most popular open source database"; }; |
There was a problem hiding this comment.
please add license and maintainer
| export PATH=$PATH:$TMPDIR | ||
| ''; | ||
|
|
||
| buildInputs = [ cmake bison ncurses openssl readline zlib perl ]; |
There was a problem hiding this comment.
tools that need to execute a build time should go in nativeBuildInputs
| buildInputs = [ cmake bison ncurses openssl readline zlib perl ]; | |
| nativeBuildInputs = [ cmake ]; | |
| buildInputs = [ bison ncurses openssl readline zlib perl ]; |
| # https://github.com/Slicer/Slicer/blob/master/License.txt | ||
| # The 3D Slicer license below is a BSD style license, with extensions | ||
| # to cover contributions and other issues specific to 3D Slicer. | ||
| maintainers = [ ]; |
| ++ ( with pkgs.qt5; [qtbase qtsvg qtwebengine qtscript qtxmlpatterns]); | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = ""; |
| @@ -0,0 +1,61 @@ | |||
| {stdenv, pkgs}: | |||
There was a problem hiding this comment.
please avoid using pkgs, and instead import each dependency individually.
This allows for things like .override() to work correctly
| pkgs.stdenv.cc.cc | ||
| pkgs.pkgs.xorg.libX11 |
There was a problem hiding this comment.
please remove pkgs usage
| pkgs.stdenv.cc.cc | |
| pkgs.pkgs.xorg.libX11 | |
| stdenv.cc.cc | |
| xorg.libX11 |
| buildInputs = | ||
| [ | ||
| pkgs.gcc-unwrapped | ||
| pkgs.autoPatchelfHook |
There was a problem hiding this comment.
goes in native build inputs
|
|
||
| buildInputs = | ||
| [ | ||
| pkgs.gcc-unwrapped |
There was a problem hiding this comment.
available at build time anyway
| pkgs.gcc-unwrapped |
| pkgs.gcc-unwrapped | ||
| pkgs.autoPatchelfHook | ||
|
|
||
| pkgs.stdenv.cc.cc |
There was a problem hiding this comment.
| pkgs.stdenv.cc.cc |
also available
There was a problem hiding this comment.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
mysql_5_6: init at 5.6.48
_3dslicer-binary: init at 4.10.2
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing because the author did not respond for quite a few months. Feel free to reopen. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Mainly adding this pull request so that others searching for it can find and run it. The SlicerApp-real runs and you can turn slices into STL which is all I cared about.