Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binwalk-full: enable visual entropy graphing (needs matplotlib) #95580

Merged
merged 1 commit into from Aug 17, 2020
Merged

binwalk-full: enable visual entropy graphing (needs matplotlib) #95580

merged 1 commit into from Aug 17, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 16, 2020

This is used for visual entropy graphing (-E argument)

Fixes #95578.

image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @asbachb

@flokli
binwalk-full: add matplotlib module
4cfcd2f 
This is used for visual entropy graphing (`-E` argument)
@flokli flokli force-pushed the binwalk-visual-entropy-graphing branch from 4015128 to 4cfcd2f Compare August 16, 2020 11:22
@flokli flokli mentioned this pull request Aug 16, 2020
Closed
@FRidh
Copy link
Member

FRidh commented Aug 16, 2020

Does it need matplotlib during build-time (e.g. because some kind of extension module needs to be compiled? Or can the same functionality be obtained by simply adding matplotlib to the runtime closure afters in python.withPackages?

@flokli
Copy link
Contributor Author

flokli commented Aug 16, 2020 via email

@flokli
Copy link
Contributor Author

flokli commented Aug 17, 2020

@FRidh binwalk and binwalk-full currently are not exposed via all-packages.nix, and only live in the python package set. I think it's fine for now to just add it to propagatedBuildInputs.

@flokli flokli merged commit d45c287 into NixOS:master Aug 17, 2020
@flokli flokli deleted the binwalk-visual-entropy-graphing branch August 17, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binwalk: Failed to import matplotlib module
2 participants
@flokli @FRidh