Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigil: 0.9.14 -> 1.3.0, addressing CVE-2019-14452 #95537

Merged
merged 1 commit into from Aug 16, 2020
Merged

sigil: 0.9.14 -> 1.3.0, addressing CVE-2019-14452 #95537

merged 1 commit into from Aug 16, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 15, 2020

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-14452

Bumped this to latest version. Package still needs some proper maintenance love e.g. elimination of vendored libs using USE_SYSTEM_LIBS (currently this causes an error involving minizip and crypto.h. This will have to do for now. Seems to work for me, non-nixos linux x86_64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
sigil: 0.9.14 -> 1.3.0
1fb0a04 
addressing CVE-2019-14452

package still needs some proper maintenance love e.g.
elimination of vendored libs. this will have to do
for now.
@mweinelt
Copy link
Member

Builds and runs.

Result of nixpkgs-review pr 95537 1

1 package built:
- sigil

@mweinelt mweinelt merged commit 9774276 into NixOS:master Aug 16, 2020
@mweinelt
Copy link
Member

Whats your plan for 20.03?

@risicle
Copy link
Contributor Author

risicle commented Aug 16, 2020

I should be able to just bump it to 0.9.16.

@risicle risicle mentioned this pull request Aug 16, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @mweinelt