Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGo{Module,Package}: remove platform.all from packages #95539

Merged
merged 2 commits into from Aug 16, 2020
Merged

buildGo{Module,Package}: remove platform.all from packages #95539

merged 2 commits into from Aug 16, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 15, 2020

buildGo{Module,Package} already sets meta.platforms.

@zowoq zowoq requested review from kalbasit and Mic92 August 15, 2020 23:01
@zowoq zowoq requested a review from Profpatsch as a code owner August 15, 2020 23:01
jonringer
jonringer approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95539 1

@jonringer jonringer merged commit a83a88d into NixOS:master Aug 16, 2020
@zowoq zowoq deleted the go-platforms branch August 16, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @jonringer