pythonPackages.Nikola: fix tests #95549
Conversation
- Use "pytest tests/" instead of "pytest ." to fix a relative import error - Apply a patch to fix markdown compilation tests - Remove a patch to requirements.txt not needed anymore
| -<span class="kn">from</span> <span class="nn">this</span> | ||
| -</pre> | ||
| +<code><span class="kn">from</span> <span class="nn">this</span> | ||
| +</code></pre> |
There was a problem hiding this comment.
there's nothing nix specific here, probably should make a patch against upstream?
There was a problem hiding this comment.
It's already fixed in upstream (from version 8.1.0 onwards). So an option to prevent including this would be to upgrade to the latest version.
There was a problem hiding this comment.
another option is to use fetchpatch, here an example: https://github.com/NixOS/nixpkgs/pull/95524/files
There was a problem hiding this comment.
Seconded - change this to a fetchpatch of the relevant upstream commit (for a github commit you can usually just add .patch to the end of the url) and I'll review this.
|
Update on this PR: I think I'll open a new PR upgrading Nikola. This avoids having to use a custom patch as done in the current PR. Right now, building Nikola in master fails because piexif, one of its dependencies, fails too. hMatoba/Piexif#108 describes the problem. I'm waiting for a response to that issue in order to proceed. |
|
you can also just force push to this branch |
|
Current Nikola in nixpkgs is updated and this PR is not needed anymore. |
pytest tests/instead ofpytest .to fix a relative import errorMotivation for this change
The build of Nikola was failing.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)