Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flam3: fix license (gpl3Only, not cc-by-nc-sa-20) #95572

Merged
merged 1 commit into from Aug 16, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Aug 16, 2020

https://github.com/scottdraves/flam3/blob/v3.1.1/COPYING

Motivation for this change

To be able to package qosmic without having to allow nonfree packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof changed the title flam3: fix license (gpl3, not cc-by-nc-sa-20) flam3: fix license (gpl3Only, not cc-by-nc-sa-20) Aug 16, 2020
@raboof raboof force-pushed the nixpkgs-flam3 branch 5 times, most recently from 144350f to 1fc9cdc Compare August 16, 2020 11:42
@raboof raboof requested a review from jtojnar August 16, 2020 11:42
@@ -19,6 +19,6 @@ stdenv.mkDerivation rec {
homepage = "https://flam3.com/";
maintainers = [ maintainers.nand0p ];
platforms = platforms.linux;
license = licenses.cc-by-nc-sa-20;
license = licenses.gpl3Only;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, you're quite right - the README doesn't specify 'any later version' but indeed each individual source file does.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please ask them to update the website/readme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raboof raboof requested a review from jtojnar August 16, 2020 12:02
@jtojnar jtojnar merged commit fc00e14 into NixOS:master Aug 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 16, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants