Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 609eb86db707
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b3909d1cb1d6
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 16, 2020

  1. nixos/systemd.tmpfiles.packages: fix an edge case

    symlinkJoin can break (silently) when the passed paths contain symlinks
    to directories.  This should work now.
    
    Down-side: when lib/tmpfiles.d doesn't exist for some passed package,
    the error message is a little less explicit, because we never get
    to the postBuild phase (and symlinkJoin doesn't provide a better way):
    /nix/store/HASH-NAME/lib/tmpfiles.d: No such file or directory
    
    Also, it seemed pointless to create symlinks for whole package trees
    and using only a part of the result (usually very small part).
    vcunat committed Aug 16, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    vcunat Vladimír Čunát
    Copy the full SHA
    3937923 View commit details
  2. Merge pull request #95565 from vcunat/p/symlinkJoin

    nixos/systemd.tmpfiles.packages: fix an edge case
    flokli authored Aug 16, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b3909d1 View commit details
Loading