Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.strictyaml: 1.0.6 -> 1.1.0 #95519

Merged
merged 1 commit into from Aug 15, 2020
Merged

python3Packages.strictyaml: 1.0.6 -> 1.1.0 #95519

merged 1 commit into from Aug 15, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 15, 2020 •
edited

Motivation for this change

noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/95519
5 packages built:
devpi-client devpi-server python27Packages.strictyaml python37Packages.strictyaml python38Packages.strictyaml

@jonringer jonringer requested a review from FRidh as a code owner August 15, 2020 18:39
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95519 1

5 packages built:
- devpi-client
- devpi-server
- python27Packages.strictyaml
- python37Packages.strictyaml
- python38Packages.strictyaml

mweinelt
mweinelt reviewed Aug 15, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you running their external tool to test this library or should we add an imports check?

@jonringer
Copy link
Contributor Author

looks like I adopted this before my big push on unit tests, I'll add pythonImportsCheck

@mweinelt
Copy link
Member

mweinelt commented Aug 15, 2020 •
edited 

builder for '/nix/store/lrqjkl6kv178jjd06qavigm2krp94s7r-python2.7-strictyaml-1.1.0.drv' failed with exit code 1; last 10 log lines:
    File "<string>", line 1, in <module>
    File "<string>", line 1, in <lambda>
    File "/nix/store/6xyf4rb6ch0xgf6c7x2p0g6l6k76yqn2-python-2.7.18/lib/python2.7/importlib/__init__.py", line 37, in import_module
      __import__(name)
    File "/nix/store/h5hma45dr2xia7ggbdx5s9qqzk7ycj7v-python2.7-strictyaml-1.1.0/lib/python2.7/site-packages/strictyaml/__init__.py", line 2, in <module>
      from strictyaml.parser import load
    File "/nix/store/h5hma45dr2xia7ggbdx5s9qqzk7ycj7v-python2.7-strictyaml-1.1.0/lib/python2.7/site-packages/strictyaml/parser.py", line 6, in <module>
      from ruamel import yaml as ruamelyaml
  ImportError: No module named ruamel
  builder for '/nix/store/lrqjkl6kv178jjd06qavigm2krp94s7r-python2.7-strictyaml-1.1.0.drv' failed with exit code 1
cannot build derivation '/nix/store/9gxikwqz6didiq60y1ixi39bpfdanpjq-env.drv': 1 dependencies couldn't be built

I guess it's time to disabled = isPy27;.

@jonringer
Copy link
Contributor Author

curious, it should be available, unless ruamel moved to a native namespace...

either way, I don't care to spend time on fixing python2 builds.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95519 1

4 packages built:
- devpi-client
- devpi-server
- python37Packages.strictyaml
- python38Packages.strictyaml

@mweinelt mweinelt merged commit 0e7f79b into NixOS:master Aug 15, 2020
@jonringer jonringer deleted the bump-strictyaml-py branch August 16, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt