Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mlflow: mark broken, missing dep #95523

Merged
merged 1 commit into from Aug 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 15, 2020

Motivation for this change

noticed it was broken reviewing: #95516

  ERROR: Could not find a version that satisfies the requirement prometheus-flask-exporter (from mlflow==1.8.0) (from versions: none)
  ERROR: No matching distribution found for prometheus-flask-exporter (from mlflow==1.8.0)
  builder for '/nix/store/lk02jqf9zv1kijg0fi740b3y898ag2dp-python3.8-mlflow-1.8.0.drv' failed with exit code 1

prometheus-flask-exporter would need to be packaged for it to work again

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant