Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alias for git tool "git brunch" #95520

Merged
merged 1 commit into from Aug 16, 2020

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Aug 15, 2020

Motivation for this change

I'm maintaining a git tool called git-brunch and want to add it to the category of git tools. Because it is written with Haskell and published on Hackage, adding an alias (similar to git-annex) is enough.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/95520
1 package built:
gitAndTools.gitBrunch

@jonringer jonringer merged commit bb472d0 into NixOS:master Aug 16, 2020
@jonringer
Copy link
Contributor

hmm didn't look at commit message, should have been:

gitAndTools.gitBrunch: init at 1.4.0.0

@jonringer
Copy link
Contributor

oh well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants